-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Configure containerd runc plugin options with systemd cgroup driver #493
Merged
Merged
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b2f1c29
fix: Configure containerd runc plugin to use systemd cgroup driver
dlipovetsky eb6788c
Use runtime type 'io.containerd.runc.v2'
dlipovetsky 42810c6
Use systemd cgroup driver with the nvidia runtime
dlipovetsky d9e4d09
Use SystemdCgroup instead of systemd_cgroup
dlipovetsky d9b1737
Use "io.containerd.runc.v2" for nvidia container runtime
dlipovetsky 5b95433
Merge branch 'main' into dlipovetsky/systemd-cgroup-default
faiq 5c9997f
fix: from poor merge
faiq c890621
fix: allows cgroups v2 by default for flatcar
faiq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this value dependent on the Kubernetes version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but as of v1.21, kubeadm
init
configures kubelet to use the systemd cgroup driver, and as of v1.22, all kubeadm commands configure kubelet to use it.Please see kubernetes/kubeadm#2376 (comment)