This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Fix boolean options for real #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the action from `store` to `store_true` and ensures the returned value for the fixture is `bool`.
kvish
approved these changes
May 18, 2018
| type=float, | ||
| help='CPU quota to set. 0.0 to set no quota.') | ||
| type=float, help='CPU quota to set. 0.0 to set no' | ||
| ' quota.') |
There was a problem hiding this comment.
72-char cutoff.
conftest.py
Outdated
| @@ -22,21 +22,20 @@ def pytest_addoption(parser): | |||
| help='Number of Jenkins masters to launch.') | |||
| parser.addoption('--jobs', action='store', default=1, type=int, | |||
| help='Number of test jobs to launch.') | |||
| parser.addoption('--single-use', action='store', default=False, | |||
| type=bool, help='Use Mesos Single-Use agents') | |||
| parser.addoption('--single-use', action='store_true', default=False, | |||
There was a problem hiding this comment.
might not need default here, since if this flag is present it is always true, makes it a little confusing for user. (same in other places)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the action from
storetostore_trueand ensures the returned value for the fixture isbool.