This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
Add Marathon on Marathon support #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add config for Marathon on Marathon.
sdk_install: - Get a Marathon app definition from a given set of install options sdk_marathon: - Support MoM in config lookup and app filtering
Add MoM support to install and uninstall for Jenkins scale tool.
colin-msphere
requested review from
gabrielhartmann,
takirala and
benclarkwood
and removed request for
benclarkwood
benclarkwood
approved these changes
May 4, 2018
| @@ -32,6 +32,24 @@ | |||
| _installed_service_names = set([]) | |||
|
|
|||
|
|
|||
| def get_package_json(package, version=None, options=None): | |||
There was a problem hiding this comment.
Note: When this merges please upstream this to dcos-commons
There was a problem hiding this comment.
Is this the correct module to put it in?
There was a problem hiding this comment.
I think it makes sense.
You're basically just getting the rendered marathon app to do a "manual" install
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add MoM support to scale tool.
This installs Jenkins instances to a single, defined (
--mom) marathon on marathon instance. This does not support installing MoM instances themselves.Cleanup also takes a MoM name and will clean the Marathon instance of Jenkins masters.