Remove duplicate Grafana dashboards

[branden]

This PR fixes an error that causes the prometheus-operator chart to generate configmaps with conflicting names.

This removes dashboards that are duplicated by these dashboards introduced with #309:

• https://github.com/mesosphere/charts/blob/2e5603b4ff1c2490923a2673ff4580a11a7a0a55/staging/prometheus-operator/templates/grafana/dashboards-1.14/apiserver.yaml
• https://github.com/mesosphere/charts/blob/2e5603b4ff1c2490923a2673ff4580a11a7a0a55/staging/prometheus-operator/templates/grafana/dashboards-1.14/controller-manager.yaml
• https://github.com/mesosphere/charts/blob/2e5603b4ff1c2490923a2673ff4580a11a7a0a55/staging/prometheus-operator/templates/grafana/dashboards-1.14/kubelet.yaml
• https://github.com/mesosphere/charts/blob/2e5603b4ff1c2490923a2673ff4580a11a7a0a55/staging/prometheus-operator/templates/grafana/dashboards-1.14/scheduler.yaml

Testing

I tested this by deploying a Konvoy cluster with the prometheus addon enabled, then deployed another cluster with the prometheus addon disabled, and deployed this modified chart to the second cluster with the addon's chart values. I then compared the affected dashboards on both clusters and observed that they looked the same.

[GoelDeepak]

Nice troubleshooting @branden :)

[gracedo]

🙌

[branden]

Looks like CI is failing on the kommander chart, for some reason:

[18:32:05]	[Step 1/2] Linting chart with values file 'staging/prometheus-operator/ci/01-provision-crds-values.yaml'...
[18:32:05]	[Step 1/2] 
[18:32:05]	[Step 1/2] >>> helm lint staging/prometheus-operator --values staging/prometheus-operator/ci/01-provision-crds-values.yaml
[18:32:05]	[Step 1/2] ==> Linting staging/prometheus-operator
[18:32:05]	[Step 1/2] Lint OK
[18:32:05]	[Step 1/2] 
[18:32:05]	[Step 1/2] 1 chart(s) linted, no failures
[18:32:05]	[Step 1/2] 
[18:32:05]	[Step 1/2] Linting chart with values file 'staging/prometheus-operator/ci/02-test-without-crds-values.yaml'...
[18:32:05]	[Step 1/2] 
[18:32:05]	[Step 1/2] >>> helm lint staging/prometheus-operator --values staging/prometheus-operator/ci/02-test-without-crds-values.yaml
[18:32:05]	[Step 1/2] ==> Linting staging/prometheus-operator
[18:32:05]	[Step 1/2] Lint OK
[18:32:05]	[Step 1/2] 
[18:32:05]	[Step 1/2] 1 chart(s) linted, no failures
[18:32:05]	[Step 1/2] Error linting charts: Error processing charts
[18:32:05]	[Step 1/2] ------------------------------------------------------------------------------------------------------------------------
[18:32:05]	[Step 1/2]  ✖︎ kommander => (version: "0.3.17", path: "stable/kommander") > Chart version not ok. Needs a version bump!
[18:32:05]	[Step 1/2]  ✔︎ prometheus-operator => (version: "8.3.8", path: "staging/prometheus-operator")
[18:32:05]	[Step 1/2] ------------------------------------------------------------------------------------------------------------------------
[18:32:05]	[Step 1/2] make: *** [ct.lint] Error 1
[18:32:05]	[Step 1/2] Makefile:105: recipe for target 'ct.lint' failed
[18:32:05]	[Step 1/2] Process exited with code 2
[18:32:05]	[Step 1/2] Process exited with code 2
[18:32:05]	[Step 1/2] Step Chart Lint (Command Line) failed

make ct.lint passes when I run it locally against this branch.

[joejulian]

Odd. The kommander chart wasn't altered. I'll merge this one.