Skip to content

Fix Comment Update job: use gh api instead of gh pr review#438

Merged
rugeli merged 6 commits intomainfrom
fix/delete-existing-comment
Dec 17, 2025
Merged

Fix Comment Update job: use gh api instead of gh pr review#438
rugeli merged 6 commits intomainfrom
fix/delete-existing-comment

Conversation

@rugeli
Copy link
Collaborator

@rugeli rugeli commented Dec 10, 2025

Problem

closes #422

a new bug was introduced in the last fix:
when new commits are pushed to an open pr, the workflow fails to delete the existing analysis report, causing duplicated comments in one pull request

Solution

  • replaced gh pr view with gh api to make sure the return id format is compatible with REST API
  • switched from delete to patch approach to avoid issues like GITHUB_TOKEN permissions

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Steps to Verify:

  1. tested by pushing test commits, verify if there is only one analysis report appears in one open pr and all jobs passed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Packing analysis report

Analysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST

Ingredient name Encapsulating radius Average number packed
ext_A 25 236.0

Packing image

Packing image

Distance analysis

Expected minimum distance: 50.00
Actual minimum distance: 50.01

Ingredient key Pairwise distance distribution
ext_A Distance distribution ext_A

@rugeli rugeli requested review from ascibisz and meganrm December 10, 2025 22:26
@rugeli rugeli merged commit 92657b0 into main Dec 17, 2025
10 checks passed
@rugeli rugeli deleted the fix/delete-existing-comment branch December 17, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use github CLI for PR comments and remove iterative/setup-cml action

3 participants