Merged
Conversation
* Add basic Dockerfile and docker-entrypoint file * draft aws cli inside of docker container * access aws s3 with saved cred * update readme * update docker commands * update readme * update readme --------- Co-authored-by: ascibisz <alli.scibisz@alleninstitute.org>
* draft aws cli inside of docker container * access aws s3 with saved cred * update readme * update docker commands * update readme * update readme * add parameter for when we're using docker to default to using the staging firebase db * read recipe and config in from docker run params * use dockerignore file to prevent bloat in docker image * add `batch_job_id` to result metadata (#295) * retrieve job id * formatting * add a bucket for batch jobs * formatting * remove print statement and add comments --------- Co-authored-by: Ruge Li <rugeli0605@gmail.com> Co-authored-by: Ruge Li <91452427+rugeli@users.noreply.github.com>
* Add Dockerfile.ecs for our ECS image and rename old Dockerfile to Dockerfile.batch * add intentional error handling for if packing fails * change messaging from /hello endpoint
…ancer requirements
…h results to cellpack-demo/
…resembles a local recipe
Contributor
Packing analysis reportAnalysis for packing results located at cellpack/tests/outputs/test_spheres/spheresSST
Packing imageDistance analysisExpected minimum distance: 50.00
|
ascibisz
force-pushed
the
feature/edited-recipes-in-firebase
branch
from
1f11992 to
b27a817
Compare
rugeli
reviewed
Jul 21, 2025
cellpack/autopack/__init__.py
Outdated
| if collection == "recipes_edited": | ||
| database_name = "firebase_edited" | ||
| return downloaded_recipe_data, database_name | ||
| return downloaded_recipe_data, database_name, collection == "recipes_edited" |
Collaborator
There was a problem hiding this comment.
returning collection == "recipes_edited" here might not be immediately clear to first time reviewers regarding how this relates to "unnested". how about using something like is_unnested_firebase or unnested_collection to clarify our intent?
Collaborator
Author
There was a problem hiding this comment.
- add local variable to clarify what's happening
meganrm
approved these changes
Jul 31, 2025
rugeli
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the cellpack-client, we want to allow users to edit recipes. Those edited recipes are uploaded to a new firebase collection,
recipes_edited, in this cellpack-client PR. Some changes are required on the cellpack side to work with this new flow, and those are in this PR.Link to story or ticket
Solution
recipes_editedcollection