Skip to content

Jitter packing results in overlaps for some parameter ranges #134

@mogres

Description

@mogres

Description

Packing a recipe with the jitter algorithm results in overlaps as detected by the analysis workflow. These overlaps can be identified in the packing image.

image

Expected Behavior

We expect the analysis workflow to not detect any overlaps.

Reproduction

pack -r cellpack/tests/recipes/test_spheres.json -c cellpack/tests/packing-configs/test_config.json
analyze -a cellpack/tests/analysis-configs/PR_analysis_config.json

#78 (comment)

Information

The overlaps are dependent on grid spacing. For a sufficiently fine grid, there are no overlaps.

Questions/directions to try:

  • Adding an option to test distances at every packing step, and throw a trace if discrepancy is detected
  • check if distance stored in the grid is reduced if an ingredient fails to pack
  • check how far an ingredient jitters from the grid point
    • square vs circle
    • radius of jitter

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions