-
Notifications
You must be signed in to change notification settings - Fork 3
Closed
Labels
bugSomething isn't workingSomething isn't working
Description
Description
Packing a recipe with the jitter algorithm results in overlaps as detected by the analysis workflow. These overlaps can be identified in the packing image.
Expected Behavior
We expect the analysis workflow to not detect any overlaps.
Reproduction
pack -r cellpack/tests/recipes/test_spheres.json -c cellpack/tests/packing-configs/test_config.json
analyze -a cellpack/tests/analysis-configs/PR_analysis_config.json
Information
The overlaps are dependent on grid spacing. For a sufficiently fine grid, there are no overlaps.
Questions/directions to try:
- Adding an option to test distances at every packing step, and throw a trace if discrepancy is detected
- check if distance stored in the grid is reduced if an ingredient fails to pack
- check how far an ingredient jitters from the grid point
- square vs circle
- radius of jitter
Reactions are currently unavailable
Metadata
Metadata
Labels
bugSomething isn't workingSomething isn't working
