Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve state performance by diffing state #389

Merged
merged 10 commits into from
Jun 9, 2024

Conversation

richard-to
Copy link
Collaborator

  • Uses DeepDiff to diff state objects
  • Updates code to return state as final data stream response

Chat Before

Screenshot 2024-06-08 at 12 57 03 PM

Chat After

Screenshot 2024-06-08 at 12 53 35 PM

Ref #62

- Uses DeepDiff to diff state objects
- Updates code to return state as final data stream response
@wwwillchen wwwillchen changed the title Improve state performance Improve state performance by diffing state Jun 8, 2024
Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of good stuff here, few questions about the implementation and a handful of minor suggestions.

Copy link
Collaborator

@wwwillchen wwwillchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@richard-to richard-to merged commit 6d63ba0 into mesop-dev:main Jun 9, 2024
3 checks passed
@richard-to richard-to deleted the state-diff branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants