Supports syntax highlighting in markdown (uses python-markdown + pygments) #203
+274
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwwillchen
force-pushed
the
pygments
branch
2 times, most recently
from
72c51b0 to
6e2c8dc
Compare
wwwillchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing the markdown rendering client-side using marked.js, this changes our markdown component's implementation to instead do it on the server-side using python-markdown for markdown rendering and pygments for syntax highlighting.
Shifting it to server-side seems better because: 1) it ships less code to client-side which is more performant and 2) most of the heavy-lifting in Mesop apps is done on the server-side already so there wasn't much benefit to doing it client side.
Addresses part of #96.