ci: don't run per-platform jobs if there's nothing to build#2673
Open
bgilbert wants to merge 1 commit intomesonbuild:masterfrom
Open
ci: don't run per-platform jobs if there's nothing to build#2673bgilbert wants to merge 1 commit intomesonbuild:masterfrom
bgilbert wants to merge 1 commit intomesonbuild:masterfrom
Conversation
The prelude job does all the sanity checks except the actual build. If it finds there's nothing to build (because there are no new releases), don't bother spawning 19 platform-specific jobs that won't have anything to do. The job could diff releases.json directly, rather than using an output from sanity_checks.py, but the latter preserves a single source of truth for when TEST_SKIP_BUILD has skipped something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prelude job does all the sanity checks except the actual build. If it finds there's nothing to build (because there are no new releases), don't bother spawning 19 platform-specific jobs that won't have anything to do.
The job could diff
releases.jsondirectly, rather than using an output fromsanity_checks.py, but the latter preserves a single source of truth for whenTEST_SKIP_BUILDhas skipped something.