Open
Conversation
apache-hb
force-pushed
the
aws-lc-1.67.0
branch
30 times, most recently
from
b3f6597 to
fda736e
Compare
apache-hb
force-pushed
the
aws-lc-1.67.0
branch
5 times, most recently
from
f238c35 to
647f321
Compare
Contributor
Author
|
I built curl from the wrapdb with aws-lc overriding openssl and could perform successful https requests to cloudflare, which I'll take to mean I got the port right at least on linux. |
apache-hb
force-pushed
the
aws-lc-1.67.0
branch
2 times, most recently
from
2d80ae9 to
aa3d435
Compare
apache-hb
force-pushed
the
aws-lc-1.67.0
branch
from
aa3d435 to
3270c41
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds version 1.67.0 of aws-lc with FIPS support. I'm not sure what the done thing for providing an alternative implementation of a library is so I opted to hide the override dependency for libcrypto and libssl behind a build option. I also used the version of s2n-bignum thats embedded in the release tarball as theres no versioned releases for it. I added
OPENSSL_IS_AWS_LCas a variable to the exported dependencies so other wraps can handle it differently as needed.