General improvments #268
Merged
General improvments #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totto16
force-pushed
the
general_improvments
branch
from
5e9c9e9 to
753fd25
Compare
fix regex and fix slicing see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/match#return_value ony why not to use the g flag
Totto16
force-pushed
the
general_improvments
branch
from
753fd25 to
7463dd9
Compare
tristan957
reviewed
Dec 9, 2024
Totto16
force-pushed
the
general_improvments
branch
from
7463dd9 to
8d8b9f8
Compare
tristan957
reviewed
Dec 10, 2024
tristan957
approved these changes
Dec 12, 2024
|
Looks good. Please squash at will, and I will merge! |
this type allows pretty printing, version comparison, and runtime checks, to detect such errors as the one fixed in the previous commit also use the proper compare methods, where we previously did it by hand add class for ToolCheckResult: it is now easier to check if it's an error or not
Totto16
force-pushed
the
general_improvments
branch
from
ef4a9d3 to
c010638
Compare
|
Squashed it to 2 commits, which makes the most sense to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some general improvements and three bug fixes, I saw when implementing #261
Bugs:
gflag was used in the regex for the version number, so the resultingmatcharray was["1.6.0"]instead of["1.6.0","1","6","0"]version[1] < 50, which only worked correctly before1.0.0(thsi never showed, since after this check we additionally check, if the returned filename is an array or not, so this only cleans this up)["1.6.0","1","6","0"].slice(1,.3)results in["1","6"]and not in three componentsImprovements:
Most of these things I "need" for #261 or at least it makes the life much more easy, (I print versions in some places, comparison is an improvement, that benefits also existing code)
Feel free to suggest any changes 😄