-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mesonlsp #219
Add mesonlsp #219
Conversation
This moves the legacy Swift-MesonLSP to Swift-MesonLSP-legacy. Users that have selected "Swift-MesonLSP" as the current language server will be automatically migrated to mesonlsp.
Please don't merge yet... I have to test it a bit more on Windows |
I would recommend just dropping the old server. VSCode allows pinning an extension if people really want it |
This is not because people e.g. prefer Swift-MesonLSP, but for example if there are any severe regressions in mesonlsp (Especially on Windows, as I didn't test it that much compared to Linux) people can easily switch back. In a few months we could drop the old language server. |
I still think that is where pinning comes into play |
I've removed all traces of Swift-MesonLSP, except that it is an alias for mesonlsp to avoid any migration difficulties. Furthermore I will release a new version today that improves cross-platform support of features (Windows now supports formatting, too) |
@tristan957 Could you please review this change, if possible as it contains important patches |
This adds the C++-Rewrite of
Swift-MesonLSP
as a separatemesonlsp
server.Swift-MesonLSP
users will be upgraded tomesonlsp
. If there are regressions, users can fallback toSwift-MesonLSP-legacy
.Issues:
And important: Before this language server is rolled out, I would like to ask adventurous people for feedback. Sure mesonlsp is perfect for my usage of meson and the usage of tristan957 (Thanks for testing!), but I think it's important to first roll it out to e.g. 10 users (That have installed
mesonlsp
by themselves and then continue with the entire rollout