Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesonlsp #219

Merged
merged 11 commits into from
Apr 9, 2024
Merged

Add mesonlsp #219

merged 11 commits into from
Apr 9, 2024

Conversation

JCWasmx86
Copy link
Contributor

@JCWasmx86 JCWasmx86 commented Mar 15, 2024

This adds the C++-Rewrite of Swift-MesonLSP as a separate mesonlsp server. Swift-MesonLSP users will be upgraded to mesonlsp. If there are regressions, users can fallback to Swift-MesonLSP-legacy.

Issues:

  • Switching language at runtime doesn't work.
  • Not sure what to do with the options (Copy paste a old?)
  • Not sure whether the changes to yarn.lock are needed
  • I'm not sure how to make this code less hacky

And important: Before this language server is rolled out, I would like to ask adventurous people for feedback. Sure mesonlsp is perfect for my usage of meson and the usage of tristan957 (Thanks for testing!), but I think it's important to first roll it out to e.g. 10 users (That have installed mesonlsp by themselves and then continue with the entire rollout

This moves the legacy Swift-MesonLSP to Swift-MesonLSP-legacy. Users
that have selected "Swift-MesonLSP" as the current language server will
be automatically migrated to mesonlsp.
@JCWasmx86 JCWasmx86 marked this pull request as ready for review March 21, 2024 17:14
@JCWasmx86
Copy link
Contributor Author

Please don't merge yet... I have to test it a bit more on Windows

@tristan957
Copy link
Contributor

I would recommend just dropping the old server. VSCode allows pinning an extension if people really want it

@JCWasmx86
Copy link
Contributor Author

JCWasmx86 commented Mar 21, 2024

This is not because people e.g. prefer Swift-MesonLSP, but for example if there are any severe regressions in mesonlsp (Especially on Windows, as I didn't test it that much compared to Linux) people can easily switch back.

In a few months we could drop the old language server.

@tristan957
Copy link
Contributor

I still think that is where pinning comes into play

@JCWasmx86
Copy link
Contributor Author

I've removed all traces of Swift-MesonLSP, except that it is an alias for mesonlsp to avoid any migration difficulties. Furthermore I will release a new version today that improves cross-platform support of features (Windows now supports formatting, too)

@JCWasmx86
Copy link
Contributor Author

@tristan957 Could you please review this change, if possible as it contains important patches

@tristan957 tristan957 merged commit 459e965 into mesonbuild:main Apr 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants