Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages for typed_kwarg type mismatches in containers #9599

Merged
merged 6 commits into from
Nov 27, 2021
Merged

Improve error messages for typed_kwarg type mismatches in containers #9599

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac137d4
run_single_test: fix running failing tests
dcbaker Nov 19, 2021
d9b4904
run_single_test: honor the --use-tmpdir flag
dcbaker Nov 19, 2021
1f63514
typed_kwargs: move some closures around to increase code clarity
dcbaker Nov 19, 2021
ecc47d6
typed_kwargs: provide better error messages for wrong container types
dcbaker Nov 19, 2021
762c504
typed_kwargs: use | for type unions, not ,
dcbaker Nov 19, 2021
d412f0a
unittests: cover cases here two of the same wrong type are provided
dcbaker Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
run_single_test: fix running failing tests
  • Loading branch information
@dcbaker
dcbaker committed Nov 22, 2021
commit ac137d4c42b5a0f5deeeaec0da7c110423d48f56
11 changes: 10 additions & 1 deletion run_single_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,16 @@ def main() -> None:
if args.subtests:
tests = [t for i, t in enumerate(tests) if i in args.subtests]

results = [run_test(t, t.args, '', True) for t in tests]
def should_fail(path: pathlib.Path) -> str:
dir_ = path.parent.stem
# FIXME: warning tets might not be handled correctly still…
if dir_.startswith(('failing', 'warning')):
if ' ' in dir_:
return dir_.split(' ')[1]
return 'meson'
return ''

results = [run_test(t, t.args, should_fail(t.path), True) for t in tests]
failed = False
for test, result in zip(tests, results):
if (result is None) or ('MESON_SKIP_TEST' in result.stdo):
Expand Down