Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prevent disabler() object from overwriting arrays #7484

Merged
merged 2 commits into from
Aug 18, 2020
Merged

prevent disabler() object from overwriting arrays #7484

merged 2 commits into from
Aug 18, 2020

Conversation

apache-hb
Copy link
Contributor

fixes #7107

@apache-hb apache-hb requested a review from jpakkane as a code owner July 20, 2020 20:30
@apache-hb
fix failing test
22fc41d 
forgot that func() != func(void) in c
@nirbheek nirbheek added this to the 0.55.1 milestone Aug 5, 2020
@jpakkane jpakkane removed this from the 0.55.1 milestone Aug 7, 2020
@nirbheek
Copy link
Member

We recently hit this downstream in gstreamer too: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1519

I think it's a safe change.

dcbaker
dcbaker approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@dcbaker dcbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems right to me too, replacing a list with a disabler because of += is rather surprising.

@dcbaker dcbaker merged commit adfee44 into mesonbuild:master Aug 18, 2020
@keszybz
Copy link
Contributor

keszybz commented Aug 18, 2020

Thanks!

@nirbheek nirbheek added this to the 0.55.2 milestone Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nirbheek nirbheek nirbheek approved these changes

@dcbaker dcbaker dcbaker approved these changes

@jpakkane jpakkane Awaiting requested review from jpakkane jpakkane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.55.2
Development

Successfully merging this pull request may close these issues.

disabler() objects convert arrays into non-arrays
5 participants
@apache-hb @nirbheek @keszybz @dcbaker @jpakkane