Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: Add more advanced subproject configuration options #7231

Merged
merged 4 commits into from
Jun 30, 2020

Conversation

mensinda
Copy link
Member

This is done with the new cmake subprojects options object that is similar to the already existing configuration data object. It is consumed by the new options kwarg of the cmake.subproject function.

@mensinda mensinda added subprojects/wraps dependency:cmake Issues related to `dependency` with the `cmake` method labels May 31, 2020
@mensinda mensinda requested a review from jpakkane as a code owner May 31, 2020 20:33
@lgtm-com

This comment has been minimized.

This is done with the new cmake subprojects options object
that is similar to the already exisiting configuration data
object. It is consumed by the new `options` kwarg of the
cmake.subproject function.

### `cmake options` object

This object is returned by the `subproject_options()` function and consumed by
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be "method", not "function".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, are all root functions of a module methods? Up until now, I have only used the term "method" for functions/methods of an object and not a module.

If "method" should also for module functions/methods I will change it for all occoruences in the CMake module docs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if "method" is the correct term here or even if an actual proper term even exists. The difference I had in mind is that "functions" look like this:

freestading_function()

whereas methods are always invoked via something else like this:

some.bound_function()

That is clearly the case when some is an object but it's less clear when it is a "module" or something similar. Anyhow, since this would require changing all the docs, let's go with this for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sure. Does this PR get a dev freeze exception then :)

@jpakkane jpakkane merged commit 64f3661 into mesonbuild:master Jun 30, 2020
@mensinda mensinda deleted the cmOverride branch July 1, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependency:cmake Issues related to `dependency` with the `cmake` method subprojects/wraps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants