-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: Add more advanced subproject configuration options #7231
Conversation
This comment has been minimized.
This comment has been minimized.
This is done with the new cmake subprojects options object that is similar to the already exisiting configuration data object. It is consumed by the new `options` kwarg of the cmake.subproject function.
|
||
### `cmake options` object | ||
|
||
This object is returned by the `subproject_options()` function and consumed by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be "method", not "function".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify, are all root functions of a module methods? Up until now, I have only used the term "method" for functions/methods of an object and not a module.
If "method" should also for module functions/methods I will change it for all occoruences in the CMake module docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if "method" is the correct term here or even if an actual proper term even exists. The difference I had in mind is that "functions" look like this:
freestading_function()
whereas methods are always invoked via something else like this:
some.bound_function()
That is clearly the case when some
is an object but it's less clear when it is a "module" or something similar. Anyhow, since this would require changing all the docs, let's go with this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, sure. Does this PR get a dev freeze exception then :)
This is done with the new cmake subprojects options object that is similar to the already existing configuration data object. It is consumed by the new
options
kwarg of the cmake.subproject function.