Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nirbheek/fix pkgconfig library dedup #3813

Merged
merged 3 commits into from
Jul 1, 2018
Merged

Nirbheek/fix pkgconfig library dedup #3813

merged 3 commits into from
Jul 1, 2018

Conversation

nirbheek
Copy link
Member

commit 405543f

pkgconfig module: Fix needlessly aggressive de-dup

commit db9ea8a

pkgconfig: Don't naively de-dup all arguments

Honestly don't know what I was smoking. Of course the `Libs:` field in
a pkg-config file can have arguments other than -l and -L

Closes https://github.com/mesonbuild/meson/issues/3800

commit b90d03b

Add a test case for bad de-dup of -framework args

https://github.com/mesonbuild/meson/issues/3800

@nirbheek
Add a test case for bad de-dup of -framework args
b90d03b 
#3800
@nirbheek
pkgconfig: Don't naively de-dup all arguments
db9ea8a 
Honestly don't know what I was smoking. Of course the `Libs:` field in
a pkg-config file can have arguments other than -l and -L

Closes #3800
@nirbheek nirbheek self-assigned this Jun 30, 2018
@nirbheek nirbheek added this to the meson-next milestone Jun 30, 2018
@nirbheek nirbheek force-pushed the nirbheek/fix-pkgconfig-library-dedup branch from 405543f to 18ed322 Compare June 30, 2018 13:27
@nirbheek nirbheek merged commit 2cbf7ca into master Jul 1, 2018
@nirbheek nirbheek deleted the nirbheek/fix-pkgconfig-library-dedup branch July 1, 2018 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nirbheek nirbheek

Labels
None yet
Projects
None yet
Milestone
meson-next
Development

Successfully merging this pull request may close these issues.
1 participant
@nirbheek