Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mercurial dist support #1920

Merged
merged 3 commits into from
Jun 21, 2017
Merged

Add Mercurial dist support #1920

merged 3 commits into from
Jun 21, 2017

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 9, 2017

I was going to copy all the git code but as far as I can tell, hg archive does everything we need except for not supporting .xz files (which can easily be approximated out of Python stdlib.)

As far as I can tell, you can't clone without subrepos, so we don't need the extra code to bundle them, and Mercurial has a flag to include subrepos (-S) in archives anyway.

@codecov-io
Copy link

codecov-io commented Jun 9, 2017

Codecov Report

Merging #1920 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1920      +/-   ##
==========================================
- Coverage   63.51%   63.46%   -0.05%     
==========================================
  Files          58       58              
  Lines       16816    16828      +12     
  Branches     3475     3476       +1     
==========================================
  Hits        10680    10680              
- Misses       5067     5079      +12     
  Partials     1069     1069
Impacted Files Coverage Δ
mesonbuild/scripts/dist.py 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75d394...eff273a. Read the comment docs.

@jpakkane
Copy link
Member

This code needs to check if the hg binary is installed and throw a skip exception if it's not.

Also, since we are in release freeze, new features will no longer be added. This will go in the next release once trunk opens.

@QuLogic
Copy link
Member Author

QuLogic commented Jun 10, 2017

It already checks for hg; that's how Travis passes. As I pointed out in IRC though, it doesn't check for vs* backend and neither does the git dist test, yet somehow the git dist test passes, which confuses me.

new features will no longer be added.

That depends on whether you consider this a new feature or just completion of an existing new feature. :P

Since only one part is needed, they can be replaced by dirname,
basename, or the originally joined file name.
@QuLogic
Copy link
Member Author

QuLogic commented Jun 13, 2017

I added a skip when not running with Ninja, but I still don't understand how the git one manages to pass on other backends.

@jpakkane jpakkane merged commit 624709b into mesonbuild:master Jun 21, 2017
@QuLogic QuLogic deleted the hg-dist branch June 21, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants