Starting to fix the typing issues in the build.py module #15414
+72
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…targets include_directories, dependencies, and link_with are all valid for jar targets as well as compiled targets.
This fixes the SharedLibrary preventing the SharedModule from being used.
We know all of the keyword arguments now! This also allows them to be removed from wrappers
These were hidden by the `if 'sources' in kwargs` check, which mypy thought would always be true, and thus it just ignored everything else. Of course, these issues are just the static type checking not understanding...
This has far reaching effects, so there's lots of related changes. There's probably more issues related to this in untyped modules. I haven't touched those.
It's in Target, but only valid for BuildTarget. It's also typed incorrectly so it's a wonder if it even works, as we pass a string into a place that needs an OptionKey
Don't put build_target stuff in the Target definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #15412
This is just some low hanging fruit.