ninjabackend: add -fmodules as a dyndeps condition #15370
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we previously only check for -fmodules-ts.
Contributor
Author
|
TODO: add a method to the |
Member
|
@mochaaP Someone else ran into this in the real world. I'd be inclined to actually merge this as-is and do the compiler thing as a follow up given that situation. This is also suitable for backport to a stable release as is. Could you rebase and convert to a real PR and then we can follow up on the rest later? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we previously only check for
-fmodules-ts.this could hypothetically be something like
Compiler.get_cpp_modules_argsfor extensibility.