Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert OptionStore from a dict to a full class with named methods #13307

Merged
merged 4 commits into from
Jun 14, 2024
Merged

Convert OptionStore from a dict to a full class with named methods #13307

merged 4 commits into from
Jun 14, 2024

Commits on Jun 8, 2024

  1. Convert option from a plain dictionary into a named class.

    @jpakkane
    jpakkane committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    2b1510d View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Rename option variable to optstore to make it unique.

    @jpakkane
    jpakkane committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    c0d8602 View commit details
    Browse the repository at this point in the history

  2. Replace direct indexing with named methods.

    @jpakkane
    jpakkane committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9a6fcd4 View commit details
    Browse the repository at this point in the history

  3. Fix mypy.

    @jpakkane
    jpakkane committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    181c349 View commit details
    Browse the repository at this point in the history