Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add D generated files to order-only deps #10464

Merged
merged 2 commits into from
Jun 19, 2022

Conversation

rtbo
Copy link
Contributor

@rtbo rtbo commented Jun 4, 2022

fixes #10463

@rtbo rtbo requested a review from jpakkane as a code owner June 4, 2022 23:27
@codecov
Copy link

codecov bot commented Jun 4, 2022

Codecov Report

Merging #10464 (50e5bd4) into master (3e2dba5) will decrease coverage by 18.56%.
The diff coverage is n/a.

❗ Current head 50e5bd4 differs from pull request most recent head e9576a4. Consider uploading reports for the commit e9576a4 to get more accurate results

@@             Coverage Diff             @@
##           master   #10464       +/-   ##
===========================================
- Coverage   68.71%   50.15%   -18.57%     
===========================================
  Files         406      203      -203     
  Lines       87766    43910    -43856     
  Branches    19518     9735     -9783     
===========================================
- Hits        60311    22024    -38287     
+ Misses      22892    19882     -3010     
+ Partials     4563     2004     -2559     
Impacted Files Coverage Δ
modules/qt5.py 0.00% <0.00%> (-100.00%) ⬇️
modules/modtest.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/run_tool.py 0.00% <0.00%> (-100.00%) ⬇️
scripts/msgfmthelper.py 0.00% <0.00%> (-100.00%) ⬇️
modules/keyval.py 0.00% <0.00%> (-95.24%) ⬇️
scripts/clangtidy.py 0.00% <0.00%> (-93.34%) ⬇️
scripts/vcstagger.py 0.00% <0.00%> (-91.67%) ⬇️
modules/unstable_icestorm.py 0.00% <0.00%> (-91.67%) ⬇️
modules/sourceset.py 0.00% <0.00%> (-90.54%) ⬇️
scripts/depscan.py 0.00% <0.00%> (-83.92%) ⬇️
... and 322 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e2dba5...e9576a4. Read the comment docs.

@tristan957
Copy link
Contributor

@dcbaker is this good to merge? Maybe you were waiting for CI to pass and just forgot about it.

@jpakkane jpakkane merged commit df4714b into mesonbuild:master Jun 19, 2022
@rtbo rtbo deleted the fix_generated_deps branch June 19, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing implicit dependency to generated code
5 participants