Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross file does not allow passing Vala compiler and args #1771

Open
oleavr opened this issue May 10, 2017 · 1 comment
Open

Cross file does not allow passing Vala compiler and args #1771

oleavr opened this issue May 10, 2017 · 1 comment
Labels
bug cross language:vala

Comments

@oleavr
Copy link
Contributor

oleavr commented May 10, 2017

Which makes sense based on the current logic:

        elif lang == 'vala':
            comp = self.environment.detect_vala_compiler()
            if need_cross_compiler:
                cross_comp = comp  # Vala compiles to platform-independent C

But I would argue that it is very useful to be able to pass -DFOO and
do #if FOO in Vala code, for the few cases where platform-dependent
Vala code is needed.
@oleavr
Copy link
Contributor Author

oleavr commented May 16, 2017

Working on a PR addressing this, I'll submit it later today.

oleavr added a commit to frida/meson that referenced this issue May 16, 2017
@oleavr
vala: Add support for cross-compilation.
57df5db 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
@oleavr oleavr mentioned this issue May 16, 2017
Closed
oleavr added a commit to frida/meson that referenced this issue May 16, 2017
@oleavr
vala: Add support for cross-compilation.
33a181c 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue May 17, 2017
@oleavr
vala: Add support for cross-compilation.
679db27 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue May 21, 2017
@oleavr
vala: Add support for cross-compilation.
5fdf515 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue May 21, 2017
@oleavr
vala: Add support for cross-compilation.
361d294 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue May 25, 2017
@oleavr
vala: Add support for cross-compilation.
a3f3a3b 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue May 25, 2017
@oleavr
vala: Add support for cross-compilation.
be125e6 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Mar 29, 2018
@oleavr
vala: Add support for cross-compilation.
9e8edba 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Jul 27, 2018
@oleavr
vala: Add support for cross-compilation.
39e91e8 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 9, 2018
@oleavr
vala: Add support for cross-compilation.
db0aea1 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 15, 2018
@oleavr
vala: Add support for cross-compilation.
e2f2a8e 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 18, 2018
@oleavr
vala: Add support for cross-compilation.
0391b43 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 18, 2018
@oleavr
vala: Add support for cross-compilation.
4219077 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 22, 2018
@oleavr
vala: Add support for cross-compilation.
36a6719 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Aug 22, 2018
@oleavr
vala: Add support for cross-compilation.
8e86356 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Apr 1, 2019
@oleavr
vala: Add support for cross-compilation.
9dbea7c 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Apr 4, 2019
@oleavr
vala: Add support for cross-compilation.
b3a1993 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Apr 4, 2019
@oleavr
vala: Add support for cross-compilation.
486f004 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
oleavr added a commit to frida/meson that referenced this issue Apr 11, 2019
@oleavr
vala: Add support for cross-compilation.
ed44e02 
It is very useful to be able to pass -DFOO and do #if FOO in Vala code,
for the few cases where platform-dependent Vala code is needed.

Fixes mesonbuild#1771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cross language:vala
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nirbheek @oleavr