Skip to content

Commit

Permalink
No longer include --scan when displaying the build command
Browse files Browse the repository at this point in the history
  • Loading branch information
jthurne committed Mar 9, 2023
1 parent d61c89e commit 2a6a10f
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 8 deletions.
8 changes: 3 additions & 5 deletions components/scripts/gradle/01-validate-incremental-building.sh
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,10 @@ execute_build() {

print_gradle_command() {
local scan_arg
if [[ "${build_scan_publishing_mode}" == "on" ]]; then
scan_arg="--scan"
else
scan_arg="-Dscan.dump"
if [[ "${build_scan_publishing_mode}" != "on" ]]; then
scan_arg=" -Dscan.dump"
fi
info "./gradlew --no-build-cache ${scan_arg} -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} $*$(print_extra_args)"
info "./gradlew --no-build-cache${scan_arg} -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} $*$(print_extra_args)"
}

fetch_build_cache_metrics() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ execute_build() {

print_gradle_command() {
if [[ "${build_scan_publishing_mode}" == "on" ]]; then
info "./gradlew --build-cache --scan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
else
info "./gradlew --build-cache -Dscan.dump -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ execute_build() {

print_gradle_command() {
if [[ "${build_scan_publishing_mode}" == "on" ]]; then
info "./gradlew --build-cache --scan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
else
info "./gradlew --build-cache -Dscan.dump -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ execute_build() {
args+=(clean ${tasks})

info "Running build:"
info "./gradlew --build-cache --scan -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"
info "./gradlew --build-cache -Dscan.tag.${EXP_SCAN_TAG} -Dscan.value.runId=${RUN_ID} clean ${tasks}$(print_extra_args)"

invoke_gradle 1 "${args[@]}"
}
Expand Down

0 comments on commit 2a6a10f

Please sign in to comment.