Skip to content

Guard against undefined values in the UI #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Avamander wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Guard against undefined values in the UI #990

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions packages/web/src/pages/Messages.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export const MessagesPage = () => {
}, true)
.map((node: Protobuf.Mesh.NodeInfo) => ({
...node,
unreadCount: getUnreadCount(node.num) ?? 0,
unreadCount: getUnreadCount(node?.num) ?? 0,
}))
.sort((a: NodeInfoWithUnread, b: NodeInfoWithUnread) => {
const diff = b.unreadCount - a.unreadCount;
Expand Down Expand Up @@ -141,7 +141,7 @@ export const MessagesPage = () => {
} else {
setMessageState({
type: MessageType.Direct,
nodeA: getMyNode().num,
nodeA: getMyNode()?.num,
nodeB: numericChatId,
messageId,
newState: MessageState.Ack,
Expand All @@ -163,7 +163,7 @@ export const MessagesPage = () => {
} else {
setMessageState({
type: MessageType.Direct,
nodeA: getMyNode().num,
nodeA: getMyNode()?.num,
nodeB: numericChatId,
messageId: failedId,
newState: MessageState.Failed,
Expand All @@ -190,7 +190,7 @@ export const MessagesPage = () => {
<ChannelChat
messages={getMessages({
type: MessageType.Direct,
nodeA: getMyNode().num,
nodeA: getMyNode()?.num,
nodeB: numericChatId,
}).reverse()}
/>
Expand Down Expand Up @@ -270,22 +270,22 @@ export const MessagesPage = () => {
>
{filteredNodes()?.map((node) => (
<SidebarButton
key={node.num}
key={node?.num}
preventCollapse
label={node.user?.longName ?? t("unknown.shortName")}
count={node.unreadCount > 0 ? node.unreadCount : undefined}
active={
numericChatId === node.num && chatType === MessageType.Direct
numericChatId === node?.num && chatType === MessageType.Direct
}
onClick={() => {
navigateToChat(MessageType.Direct, node.num.toString());
resetUnread(node.num);
navigateToChat(MessageType.Direct, node?.num.toString());
resetUnread(node?.num);
}}
>
<Avatar
nodeNum={node.num}
className={cn(hasNodeError(node.num) && "text-red-500")}
showError={hasNodeError(node.num)}
nodeNum={node?.num}
className={cn(hasNodeError(node?.num) && "text-red-500")}
showError={hasNodeError(node?.num)}
showFavorite={node.isFavorite}
size="sm"
/>
Expand Down