Skip to content

Conversation

danditomaso
Copy link
Collaborator

Description

This PR prevents a user from clicking the Connect button in the new Device Dialog multiple times, which creates additional unconnected nodes and as a result unexpected UI errors.

Related Issues

Fixes #564

Changes Made

  • Added new state in parent, which is passed through props to each tab. This ensures state is coordinated when a connection is attempted.
  • Passed connection state through props, eliminated local state in favour of parent state.

Testing Done

  • Attempted to click Connect multiple times after implimenting solution, was prevented from creating additional connections.

Checklist

  • Code follows project style guidelines
  • Documentation has been updated or added
  • Tests have been added or updated
  • All CI checks pass
  • Dependent changes have been merged

@danditomaso danditomaso requested a review from Hunter275 April 8, 2025 00:41
Copy link

vercel bot commented Apr 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-test ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2025 0:42am

@danditomaso danditomaso merged commit c95a819 into meshtastic:master Apr 8, 2025
4 checks passed
@danditomaso danditomaso deleted the issue-564-multiple-connect-clicks-on-connect-dialog branch April 8, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Multiple connections if Connect button clicked multiple times.
2 participants