fix(power): reset LPF when adc_multiplier_override changes at runtime #9509
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
@lexfrei, Welcome to Meshtastic!Thanks for opening your first pull request. We really appreciate it. We discuss work as a team in discord, please join us in the #firmware channel. Welcome to the team 😄 |
The Low Pass Filter for battery voltage readings was not resetting when power.adc_multiplier_override was changed at runtime. This caused the new multiplier value to take effect only after slow LPF convergence (~1-2 minutes) instead of immediately. Add tracking of the last used ADC multiplier and reset initial_read_done flag when the multiplier changes, allowing runtime calibration to take effect on the next ADC reading. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Aleksei Sviridkin <f@lex.la>
lexfrei
force-pushed
the
fix/adc-multiplier-runtime
branch
from
2dee204 to
cb6e713
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where runtime changes to power.adc_multiplier_override configuration had no immediate effect on battery voltage readings due to the Low Pass Filter (LPF) slowly converging to the new value over 1-2 minutes.
Changes:
- Added tracking of the last used ADC multiplier value via a new member variable
last_adc_multiplier - Reset the LPF initialization state (
initial_read_done) when the multiplier changes at runtime - Ensures immediate application of new multiplier values instead of slow LPF convergence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
power.adc_multiplier_overridechanges at runtimeinitial_read_doneflag when it changesProblem
When changing
power.adc_multiplier_overrideat runtime, the new value is saved but has no visible effect on battery voltage readings for 1-2 minutes due to the LPF slowly converging to the new value.The LPF uses a cached
last_read_valuecalculated with the old multiplier, and theinitial_read_doneflag (set on first reading) prevents immediate application of the new multiplier.Solution
Add a member variable to track the last used multiplier. When the multiplier changes, reset
initial_read_donetofalse, causing the next ADC reading to initialize the filter directly with the new scaled value.Test plan
power.adc_multiplier_overridevia CLIFixes #9508