BaseUI: Implementation of Status Message for Favorite and NodeList views #9504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xaositek
added
enhancement
jp-bennett
reviewed
Feb 2, 2026
Contributor
Author
|
|
Contributor
Author
|
|
Xaositek
changed the title
jp-bennett
reviewed
Feb 3, 2026
src/modules/StatusMessageModule.h
Outdated
| virtual ProcessMessage handleReceived(const meshtastic_MeshPacket &mp) override; | ||
|
|
||
| private: | ||
| static constexpr size_t MAX_RECENT_STATUSMESSAGES = 20; |
Collaborator
There was a problem hiding this comment.
This ends up being quite a bit of memory on constrained devices. I'm still of the opinion this should be reduced, and possibly limited to devices that are favorited.
Contributor
Author
There was a problem hiding this comment.
I originally set it at 5, I can move it back but I think display wise, there's more value of the implementation if we use it on more than just the Favorite frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.