Drop NodeInfo packets if the is_licensed bit doesn't match owner #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a validation step to drop incoming NodeInfo packets when the is_licensed flag doesn’t match the local owner’s flag, preventing acceptance of invalid packets.
- Introduce a guard in
handleReceivedProtobufto comparep.is_licensedwithowner.is_licensed - Log a warning and return early to drop mismatched packets
Comments suppressed due to low confidence (1)
src/modules/NodeInfoModule.cpp:17
- There should be unit or integration tests covering both matching and mismatching
is_licensedscenarios to verify that packets are correctly accepted or dropped.
if (p.is_licensed != owner.is_licensed) {
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While triaging other issues, it became apparent that we accept invalid NodeInfo packets, regarding is_licensed. Closing that loophole