Message frame New Message Options and Clock / TDeck / Brightness Refinements

[Xaositek]

• Message frame has default options for new messages
• Clock updates for Chatter 2 and TDeck
• Remove Brightness Settings for HAS_TFT flag

[Copilot]

Pull Request Overview

This PR introduces a new base menu for composing messages, refines clock display behavior for Chatter 2 and TDeck, and adjusts brightness and navigation logic across menus.

• Add textMessageBaseMenu and route navigation when no incoming message exists
• Update ClockRenderer to support CHATER_2 scaling and T_DECK y-offset, and remove an unused variable
• Revise brightness support flags in screenOptionsMenu and include T_DECK in TFT color picker
• Shift header icon positioning and improve text message menu flow in Screen::handleInputEvent

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/graphics/draw/MenuHandler.h	Declared new textMessageBaseMenu prototype
src/graphics/draw/MenuHandler.cpp	Implemented textMessageBaseMenu and updated menu flags
src/graphics/draw/ClockRenderer.cpp	Added scale and yOffset adjustments for CHATER_2 and T_DECK; removed unused line variable
src/graphics/SharedUIDisplay.cpp	Adjusted iconRightEdge calculation from -1 to -2
src/graphics/Screen.cpp	Updated input handling to show base or response message menu

Comments suppressed due to low confidence (3)

src/graphics/draw/MenuHandler.cpp:349

• [nitpick] The enum name 'optionsNumbers' and member 'enumEnd' are ambiguous. Consider renaming to something like 'TextMessageOption' and 'OptionCount' for clearer intent.

    enum optionsNumbers { Back, Preset, Freetext, enumEnd };

src/graphics/draw/MenuHandler.cpp:347

• [nitpick] This new menu introduces user-facing options and a lambda callback. Consider adding unit or integration tests to validate both the Preset and Freetext branches and when kb_found is true or false.

void menuHandler::textMessageBaseMenu()

src/graphics/draw/ClockRenderer.cpp:290

• Double-check that this added #endif matches the correct #ifdef (SENSECAP_INDICATOR) and doesn’t prematurely close another block, which could lead to missing code under certain builds.

#endif