Map report should work over devices which do not have network hardware (with client proxy)#7341
Merged
thebentern merged 2 commits intomasterfrom Jul 15, 2025
Merged
Map report should work over devices which do not have network hardware (with client proxy)#7341thebentern merged 2 commits intomasterfrom
thebentern merged 2 commits intomasterfrom
Conversation
…e (with client proxy)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables map reporting functionality on devices without network hardware by allowing them to use a client proxy connection. The change restructures the MQTT runOnce() method to check for enabled MQTT features and establish connection desire before verifying network hardware availability.
- Moved MQTT feature enablement check outside the HAS_NETWORKING conditional block
- Repositioned HAS_NETWORKING check to only guard network-specific operations like pubSub.loop()
Member
|
Yay, this was confusing |
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 21, 2025
…e (with client proxy) (meshtastic#7341) * Map report should work over devices which do not have network hardware (with client proxy) * Fix else
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 22, 2025
…e (with client proxy) (meshtastic#7341) * Map report should work over devices which do not have network hardware (with client proxy) * Fix else
oscgonfer
pushed a commit
to fablabbcn/smartcitizen-meshtastic
that referenced
this pull request
Jul 23, 2025
…e (with client proxy) (meshtastic#7341) * Map report should work over devices which do not have network hardware (with client proxy) * Fix else
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.