Skip to content

Conversation

@scruplelesswizard
Copy link
Contributor

Description

Creates an action with common build steps across the following variants:

  • ESP32
  • ESP32-C3
  • ESP32-S3
  • NRF52
  • Raspberry Pi 2040
  • STM32

Iterations

@scruplelesswizard scruplelesswizard changed the title Variant build poc Consolidate variant build steps Sep 22, 2024
@fifieldt
Copy link
Member

Let's give this another go.

@fifieldt fifieldt merged commit b4c09ac into meshtastic:master Sep 24, 2024
@fifieldt
Copy link
Member

No good:

Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 43, Col: 11): Unexpected symbol: '"true"'. Located at position 26 within expression: inputs.include-web-ui == "true"
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 52, Col: 11): Unexpected symbol: '"true"'. Located at position 26 within expression: inputs.include-web-ui == "true"
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 60, Col: 11): Unexpected symbol: '""'. Located at position 30 within expression: inputs.remove-debug-flags != ""
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 71, Col: 11): Unexpected symbol: '""'. Located at position 31 within expression: inputs.ota-firmware-source != "" && inputs.ota-firmware-target != ""
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 43, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.include-web-ui == "true" }}
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 52, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.include-web-ui == "true" }}
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 60, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.remove-debug-flags != "" }}
Error: /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 71, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.ota-firmware-source != "" && inputs.ota-firmware-target != "" }}
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 43, Col: 11): Unexpected symbol: '"true"'. Located at position 26 within expression: inputs.include-web-ui == "true",/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 52, Col: 11): Unexpected symbol: '"true"'. Located at position 26 within expression: inputs.include-web-ui == "true",/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 60, Col: 11): Unexpected symbol: '""'. Located at position 30 within expression: inputs.remove-debug-flags != "",/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 71, Col: 11): Unexpected symbol: '""'. Located at position 31 within expression: inputs.ota-firmware-source != "" && inputs.ota-firmware-target != "",/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 43, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.include-web-ui == "true" }},/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 52, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.include-web-ui == "true" }},/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 60, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.remove-debug-flags != "" }},/home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml (Line: 71, Col: 11): Unexpected symbol: '${{'. Located at position 1 within expression: ${{ inputs.ota-firmware-source != "" && inputs.ota-firmware-target != "" }}
at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
at GitHub.Runner.Worker.ActionManifestManager.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
at GitHub.Runner.Worker.ActionManifestManager.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load /home/runner/work/firmware/firmware/./.github/actions/build-variant/action.yml

fifieldt added a commit that referenced this pull request Sep 24, 2024
@scruplelesswizard scruplelesswizard deleted the variant-build-poc branch September 28, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants