Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for M5Stack CoreS3 board #958

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lboue
Copy link

@lboue lboue commented Oct 9, 2024

What changed?

  • DeviceHardware.json
  • mesh.pb.swift

Why did it change?

Support M5Stack CoreS3 board

Defined in protobufs:
https://github.com/meshtastic/protobufs/blob/c9ae7fd478bffe5f954b30de6cb140821fe9ff52/meshtastic/mesh.proto#L637

How is this tested?

I can't compile with GitPod

Screenshots/Videos (when applicable)

Checklist

  • My code adheres to the project's coding and style guidelines.
  • I have conducted a self-review of my code.
  • I have commented my code, particularly in complex areas.
  • I have made corresponding changes to the documentation.
  • I have tested the change to ensure that it works as intended.

Support M5Stack CoreS3 board
Support for M5Stack CoreS3
@lboue
Copy link
Author

lboue commented Oct 9, 2024

Could you tell me how to modify the documentation.

Unfortunately I don't have a Mac to run scripts/gen_protos.sh the script.

@lboue lboue marked this pull request as ready for review October 9, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant