Repository navigation
ci: teach actionlint the ubuntu-26.04 runner labels - #7226
Conversation
main is red. The runners moved to ubuntu-26.04 and ubuntu-26.04-arm, and the actionlint pinned in pull-request.yml (1.7.12) predates both, so it reports 26 unknown-label findings across 20 workflow files and fails Check Store Metadata on every branch cut from main - not just on PRs that touch a workflow. .github/actionlint.yaml did not exist. The self-hosted-runner key is the only mechanism actionlint offers for declaring a label it does not know; these two are ordinary GitHub-hosted runners despite the key's name. Scoped to the two labels in use rather than switched off: a made-up label is still reported with this config in place.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds an actionlint configuration file. It registers ChangesActionlint runner label configuration
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to This change should allow the intended Ubuntu 26.04 runner labels without introducing a material merge risk. 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Why
mainis red, and every branch cut from it inherits the failure.The runners moved to
ubuntu-26.04/ubuntu-26.04-arm, but the actionlint pinned inpull-request.yml:290is 1.7.12, which does not know those labels. It reports 26 unknown-label findings across 20 workflow files and failsCheck Store Metadata→Lint GitHub workflows (actionlint).The step lints the whole directory, so this fails on PRs that touch no workflow at all:
.github/actionlint.yamldid not exist.Why not just bump actionlint
Checked, and there is nothing to bump to:
mainupstream doesn't know the label either —rule_runner_label.golists onlyubuntu-22.04,ubuntu-22.04-arm,ubuntu-24.04,ubuntu-24.04-arm. Building from HEAD would not help.So this config is the only available fix until upstream lands support.
🛠️ Build
.github/actionlint.yamldeclaring the two labels.The key is named
self-hosted-runner, but these are ordinary GitHub-hosted runners — it is simply actionlint's only mechanism for teaching it a label it doesn't know. Noted in a comment, with the removal condition.Testing Performed
Reproduced with the exact version CI installs (
download-actionlint.bash 1.7.12):origin/main(8f1f1392c), extracted cleanIt does not disable the check. With the config in place, substituting a made-up label is still reported:
The allowance is scoped to the two labels actually in use.
Note
Found while diagnosing a failure on #7221, which I first assumed was mine — it wasn't. Every other open PR in the repo is failing the same way, so this unblocks them too.
Summary by CodeRabbit