refactor: SettingsFragment to compose #1516
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stic-Android into settings_refactor
|
|
materoy
changed the title
|
Thanks for your contribution! As a general guideline, we want to follow the design of a traditional Settings/Preference screen, making use of our existing "Preference" components (like SwitchPreference and DropdownPreference). The BLE/TCP/Serial device scan/selection could probably move to an item in the Settings screen to maintain a cleaner layout, but open to ideas and suggestions on how best to organize this. Items currently in the overflow menu, like Theme and Language, will also be moved into this screen in the future. |
andrekir
reviewed
Jan 3, 2025
| devices.value = mutableMapOf<String, DeviceListEntry>().apply { | ||
| fun addDevice(entry: DeviceListEntry) { this[entry.fullAddress] = entry } | ||
| suspend fun addDevice(entry: DeviceListEntry) { | ||
| _uiState.emit(uiState.value.copy(devices = uiState.value.devices + (entry.fullAddress to entry))) |
There was a problem hiding this comment.
use MutableStateFlow .update {} instead of .emit
# Conflicts: # app/src/main/java/com/geeksville/mesh/model/BTScanModel.kt # app/src/main/proto
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SettingsFragmentto Compose #1432This pr is a refactor of
SettingsFragmenttoSettingsScreenin composeStill in draft phase, almost complete, feel free to review, suggest edits and bug fixes