Skip to content

fix: programs stylesheet inclusion logic and responsive issues on related pages #2323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

fix: programs stylesheet inclusion logic and responsive issues on related pages #2323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
54f4f5b
fix: logic for programs stylesheet inclusion on related pages
arctic-beep Aug 10, 2025
6eb7bdc
responsive fixes for li, a and h3 tags on programs pages
arctic-beep Aug 10, 2025
28dcd11
Update css/program.css
arctic-beep Aug 10, 2025
09cf4bf
Merge branch 'master' into patch-488
arctic-beep Aug 11, 2025
712f9a3
fix contains logic
arctic-beep Aug 11, 2025
254154f
rm redundant font size style for project-title
arctic-beep Aug 12, 2025
4b9cbc1
add if
arctic-beep Aug 12, 2025
1bdbc1a
fix unwanted padding in < 768px screen width
arctic-beep Aug 12, 2025
2b9d087
Merge branch 'master' into patch-488
arctic-beep Aug 15, 2025
23042af
Merge branch 'master' into patch-488
vr-varad Aug 17, 2025
d7d21b6
Merge branch 'master' into patch-488
arctic-beep Aug 31, 2025
c89b9ab
Merge branch 'master' into patch-488
vr-varad Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions _includes/header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,8 @@
/>
<link rel="stylesheet" href="{{ site.baseurl }}/css/subscribe.css" />

{% if page.title == 'Programs' or page.title == 'CNCF' or page.title ==
'LFX' or page.title == 'Google Summer of Code 2019' or
page.title == 'Google Summer of Code' or page.title == 'GSOD2020' or
page.title == 'MLH' %}
{% assign page_title_lc = page.title | strip | downcase %}
{% if page_title_lc == 'programs' or page_title_lc == 'cncf' or (page_title_lc contains 'lfx') or (page_title_lc contains 'google summer of code') or page_title_lc == 'gsod2020' or page_title_lc == 'mlh' %}
<link rel="stylesheet" href="{{ site.baseurl }}/css/program.css" />
{% endif %}

Expand Down Expand Up @@ -148,4 +146,4 @@
</div>
</header>
</body>
</html>
</html>
1 change: 0 additions & 1 deletion css/program.css
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rajesh-Nagarajan-11 @vr-varad the font size for heading h3 which is currently overflowing on lfx/2025 pages is already accounted for in this sheet on line number 45. If this stylesheet were applied to lfx pages, we wouldn't have that overflowing heading in the first place ( check GSoC/2025 pages for example).

The only fix needed to make GSoC and lfx page fully responsive in < 350px screen width is to ensure proper line wrapping for li and a which is included in this PR.
Take a look and feel free to share any suggestions/thoughts

Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ img {
padding-left: 0.6rem;
}


.cncf-firstrow {
max-width: 1400px;
border: 2px solid #00d4ab;
Expand Down
Loading