Contact management tweaks #1408
Open
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of small tweaks to the contact management that were previously proposed against the old contact management system. This supercedes #1369 and #1362.
Changes:
@ripplebiz I've tested it pretty thoroughly and it seems to work as intended. I'm not a huge fan of the name of
bool is_newbut I've attempted to be clear on it's meaning/use in the comments. Happy to change it in the onDiscovereContact sig if you have any suggestions, it just means updating simple_secure_chat as well.@liamcottle You might want to tweak the notifications for the app, since now if we are full we still send PUSH_CODE_NEW_ADVERT which means we pop two notifications at the same time.