T1000-E: Negative temperature values incorrectly displayed due to char signedness #1391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ntc_temp2array type fromchartoint8_tProblem
The
ntc_temp2lookup table invariants/t1000-e/t1000e_sensors.cppwas declared aschar, which can be unsigned on some platforms (depending on compiler defaults). This caused negative temperature values (from -30°C to -1°C) to be incorrectly interpreted as large positive values.Solution
Changed the array declaration from:
to:
This ensures the array is always treated as signed, allowing proper handling of negative temperatures.
Impact
Test plan
Fixes #1389
🤖 Generated with Claude Code