fix dat.GUI button elements layout #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdeits
reviewed
Sep 7, 2021
| // the callback was not called. | ||
| viewer.set_control_value("TestSlider", .4, false); | ||
|
|
||
| viewer.set_control("Test button with a really long name", () => { |
Collaborator
There was a problem hiding this comment.
Can you change this file to include main.min.js? It currently uses main.js which isn't tracked in git
Collaborator
Author
There was a problem hiding this comment.
Done. (I had copied it from empty_scene.html)
RussTedrake
force-pushed
the
long_button_names
branch
from
f8a7913 to
0569c77
Compare
without this fix, buttons added to the GUI with a long name were artificially truncated to the same length that a slider name gets truncated (to make room for the slider and text input). The button should not have that restriction. After this fix, the complete long name of the button is displayed properly.
RussTedrake
force-pushed
the
long_button_names
branch
from
0569c77 to
3e23508
Compare
Collaborator
Author
|
FWIW, I've also gone ahead and PR'd the upstream fix. dataarts/dat.gui#306 . If that goes through, then we can bump the dependency and get rid of the one-line bandaid. But I would like to land this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this fix, buttons added to the GUI with a long name were artificially truncated to the same length that a slider name gets truncated (to make room for the slider and text input). The button should not have that restriction.
After this fix, the complete long name of the button is displayed properly.