Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Mask environment configuration with no_log #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dekimsey
Copy link
Contributor

I ran into this when I was configuring the mongo exporter, it requires me to set credentials via environment variables.

Environment files are frequently used to inject sensitive values to daemons; this change enables the no_log flag on this task.

Alternatively, we could have two tasks that do the same thing and require users to opt out/in perhaps something like this:

prometheus_my_exporter_env_vars:
   foo: 'not a secret, i like my diffs'
prometheus_my_exporter_env_insensitive: true

Environment files are frequently used to inject sensitive values to daemons. This change enables the no_log flag on this task.

Alternatively, we could have two tasks that do the same thing and require users to opt out/in like such:

```yaml
prometheus_my_exporter_env_vars:
   foo: 'not a secret, i like my diffs'
prometheus_my_exporter_env_insensitive: true
```
@dekimsey
Copy link
Contributor Author

Looks like some other exporters use configuration file based bits that pass credentials around. So I'm thinking this may need to be scoped out a bit more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant