Merged
Conversation
Add rename method to FsDataProvider with default EROFS, implement it on MockFsDataProvider with call tracking, and create 8 rename test cases. Tests won't compile until AsyncFs::rename is implemented.
…t provider notification
- Return EINVAL for RENAME_EXCHANGE, RENAME_WHITEOUT, RENAME_NOREPLACE flags since only plain rename is supported. - Add early return for no-op renames where old and new paths are identical.
markovejnovic
force-pushed
the
marko/mes-860-support-renaming-files
branch
from
0f234a7 to
88f8a32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.