Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get() method throws error on undefined records #18

Closed
mertssmnoglu opened this issue May 3, 2024 · 0 comments · Fixed by #19
Closed

get() method throws error on undefined records #18

mertssmnoglu opened this issue May 3, 2024 · 0 comments · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@mertssmnoglu
Copy link
Owner

To check if the record exists or not, get method should return undefined or ClientRateLimitInfo
Currently when the record is not exists, it throws error because of the try-catch block. It fails on tests.

Try Catch method can be removed. Returning undefined | ClientRateLimitInfo is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant