fix: clarify Tailwind scoping with .zenuml class #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move .zenuml class to wrapper div in core.tsx for proper Tailwind scoping - Remove redundant .zenuml class from DiagramFrame component - Add comments explaining how Tailwind's important: ".zenuml" configuration works - This ensures Tailwind utilities work correctly as child selectors (.zenuml .p-1) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.zenumlclass to wrapper div in core.tsx for proper Tailwind scoping.zenumlclass from DiagramFrame componentProblem
The Tailwind configuration uses
important: ".zenuml"which generates selectors like.zenuml .p-1(with a space). This means Tailwind utilities only work on elements that are descendants of.zenuml, not on elements that have the.zenumlclass themselves.Having
.zenumlon the DiagramFrame component along with Tailwind utilities likep-1 bg-skin-canvas inline-blockwas confusing because those utilities wouldn't actually work there.Solution
.zenumlonly on the parent wrapper div in core.tsxThis maintains the same DOM structure and functionality while making the code clearer.
🤖 Generated with Claude Code