Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #5810

Merged
merged 166 commits into from
Sep 2, 2024
Merged

Release #5810

merged 166 commits into from
Sep 2, 2024

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented Sep 2, 2024

📑 Summary

Brief description about the content of your PR.

Resolves #

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

jobs:
release:
permissions:
contents: write # for changesets/action to push to the repo

Check failure

Code scanning / Scorecard

Token-Permissions High

score is 0: jobLevel 'contents' permission set to 'write'
Remediation tip: Verify which permissions are needed and consider whether you can reduce them.
Click Remediation section below for further remediation help
Copy link

changeset-bot bot commented Sep 2, 2024

🦋 Changeset detected

Latest commit: 87fa9e5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Sep 2, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 87fa9e5
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66d5d1430f95e600086e7515
😎 Deploy Preview https://deploy-preview-5810--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

argos-ci bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ Reference build (Review) 670 added, 1 failure Sep 2, 2024, 2:59 PM

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 0.53243% with 2055 lines in your changes missing coverage. Please review.

Project coverage is 5.01%. Comparing base (755394a) to head (87fa9e5).
Report is 170 commits behind head on master.

Files with missing lines Patch % Lines
.../src/diagrams/architecture/architectureRenderer.ts 0.00% 466 Missing ⚠️
...kages/mermaid/src/diagrams/architecture/svgDraw.ts 0.00% 370 Missing ⚠️
...aid/src/diagrams/architecture/architectureTypes.ts 0.00% 351 Missing ⚠️
...ermaid/src/diagrams/architecture/architectureDb.ts 0.00% 333 Missing ⚠️
packages/mermaid/src/rendering-util/icons.ts 0.00% 100 Missing ⚠️
...ackages/parser/src/language/architecture/module.ts 0.00% 79 Missing ⚠️
...rc/rendering-util/layout-algorithms/dagre/index.js 0.00% 58 Missing ⚠️
...aid/src/diagrams/architecture/architectureIcons.ts 0.00% 43 Missing ⚠️
...id/src/diagrams/architecture/architectureStyles.ts 0.00% 38 Missing ⚠️
packages/mermaid-layout-elk/src/render.ts 0.00% 28 Missing ⚠️
... and 21 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #5810      +/-   ##
=========================================
- Coverage    5.21%   5.01%   -0.20%     
=========================================
  Files         322     337      +15     
  Lines       46094   48084    +1990     
  Branches      561     550      -11     
=========================================
+ Hits         2402    2413      +11     
- Misses      43692   45671    +1979     
Flag Coverage Δ
unit 5.01% <0.53%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid/src/themes/theme-default.js 94.52% <100.00%> (+0.15%) ⬆️
packages/parser/src/language/pie/valueConverter.ts 0.00% <ø> (ø)
.build/jsonSchema.ts 0.00% <0.00%> (ø)
packages/mermaid/src/docs/.vitepress/config.ts 0.00% <0.00%> (ø)
packages/parser/src/language/architecture/index.ts 0.00% <0.00%> (ø)
...g-util/layout-algorithms/dagre/mermaid-graphlib.js 0.00% <0.00%> (ø)
...s/mermaid/src/diagram-api/diagram-orchestration.ts 0.00% <0.00%> (ø)
packages/mermaid/src/mermaid.ts 0.00% <0.00%> (ø)
.../mermaid/src/diagrams/flowchart/flowDetector-v2.ts 0.00% <0.00%> (ø)
packages/parser/src/language/index.ts 0.00% <0.00%> (ø)
... and 23 more

... and 1 file with indirect coverage changes

Copy link
Collaborator Author

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants