Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flowchart.diagramPadding config option #1533

Merged

Conversation

72636c
Copy link
Contributor

@72636c 72636c commented Jul 11, 2020

📑 Summary

This option lets you customise the padding around the whole flowchart.

📏 Design Decisions

  • Equivalent to er.diagramPadding, so is named as such
  • Defaults to 8px for backwards compatibility with the current hardcoded value

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

72636c added 2 commits July 11, 2020 16:54
This option lets you customise the padding around the whole flowchart.
It is equivalent to `er.diagramPadding` and defaults to 8px for
backwards compatibility with the current hardcoded value.
Copy link
Collaborator

@knsv knsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Appreciate that you added the rendering tests and the new config options to the docs.

@knsv knsv merged commit e66f7f0 into mermaid-js:develop Jul 12, 2020
@72636c 72636c deleted the feature/config_flowchart_diagram_padding branch July 12, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants