Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1378 additional qualifiers bug with multiple arguments #1446

Merged
merged 8 commits into from
Jun 10, 2020
Merged

1378 additional qualifiers bug with multiple arguments #1446

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
97b8684
Merge pull request #21 from mermaid-js/develop
jgreywolf May 27, 2020
6298a7a
Merge pull request #22 from mermaid-js/develop
jgreywolf Jun 9, 2020
47b5d7a
1378-accept multiple parameters with methods
jgreywolf Jun 6, 2020
9091d68
1378-Update regex to match multiple parameters
jgreywolf Jun 9, 2020
ae6b75b
Removed additional unintended change
jgreywolf Jun 9, 2020
0495103
Fix regex and Fix incorrect test
jgreywolf Jun 9, 2020
969a4e7
1378-refine legacy member parsing to cover additional cases
jgreywolf Jun 9, 2020
67e1674
1378-Added additional test
jgreywolf Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
1378-Added additional test
  • Loading branch information
@jgreywolf
jgreywolf committed Jun 9, 2020
commit 67e167427cbfac981afbcaafbc5595c1b49a7b44
8 changes: 8 additions & 0 deletions src/diagrams/class/svgDraw.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ describe('class member Renderer, ', function () {
expect(actual.cssStyle).toBe('');
});

it('should handle simple method declaration with multiple parameters', function () {
const str = 'foo(int id, object thing)';
let actual = svgDraw.parseMember(str);

expect(actual.displayText).toBe('foo(int id, object thing)');
expect(actual.cssStyle).toBe('');
});

it('should handle simple method declaration with single item in parameters', function () {
const str = 'foo(id)';
let actual = svgDraw.parseMember(str);
Expand Down