Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify theming #1542

Closed
knsv opened this issue Jul 14, 2020 · 0 comments · Fixed by #1554 or #1586
Closed

Simplify theming #1542

knsv opened this issue Jul 14, 2020 · 0 comments · Fixed by #1554 or #1586
Assignees
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request

Comments

@knsv
Copy link
Collaborator

knsv commented Jul 14, 2020

As an integrator integrating mermaid to a site or a too,l theming might is timeconsuming. There to many options and parameters to change making it difficult.

Instead of overriding the css there should be a base set of theming parameters to set that are easy to understand without going deep into the svg markup of a generated mermaid svg. These parameters should then generate the theme dynamically.

  • The less colors to customize the better
  • The easier it is to extract all color-related CSS properties the better
  • Add sample mermaid diagrams that used all colors, make rendering test with supported themes for those diagrams
  • Add those sample diagrams to the live editor for easy access
@knsv knsv added Type: Enhancement New feature or request Topic: Platform labels Jul 14, 2020
@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label Jul 14, 2020
@knsv knsv self-assigned this Jul 16, 2020
knsv added a commit that referenced this issue Jul 17, 2020
knsv added a commit that referenced this issue Jul 17, 2020
knsv added a commit that referenced this issue Jul 18, 2020
knsv added a commit that referenced this issue Jul 18, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 18, 2020
@knsv knsv reopened this Jul 29, 2020
@github-actions github-actions bot unlocked this conversation Jul 29, 2020
knsv added a commit that referenced this issue Jul 29, 2020
…riables using initialize call or directives + tests
knsv added a commit that referenced this issue Jul 29, 2020
@knsv knsv mentioned this issue Jul 29, 2020
3 tasks
knsv added a commit that referenced this issue Jul 30, 2020
knsv added a commit that referenced this issue Jul 30, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant