Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre iOS 9 Core Data related crashes #169

Merged
merged 3 commits into from
Jun 9, 2020
Merged

Conversation

vincentneo
Copy link
Collaborator

@vincentneo vincentneo commented Jun 7, 2020

Fix #168.

Fixes an issue where the app will crash on launch.

Occurs after using any methods that involves NSFetchRequestResult, which is unavailable in iOS 9, but was not known as it wasn't flagged out by compiler when in development.

Tested to be able to recover from the launch crash loop, in simulated environment.

@vincentneo vincentneo requested a review from merlos June 7, 2020 15:20
@merlos merlos merged commit 891b1f2 into master Jun 9, 2020
@merlos
Copy link
Owner

merlos commented Jun 9, 2020

Thanks @vincentneo

@merlos merlos deleted the fix/legacyCoreData branch June 11, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashing on ipad
2 participants