Skip to content

v0.0.1 patch from stainlessbot #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2023
Merged

v0.0.1 patch from stainlessbot #4

merged 2 commits into from
May 18, 2023

Conversation

leewang0
Copy link
Contributor

@leewang0 leewang0 commented May 18, 2023

Opening this PR to check if there's anything remaining left to do on our end.

Status / TODOs:

[x] Don't delete .github/workflows/tests.yml
[x] Check why there is a diff for LICENSE.md

Handwritten changes:

Moved tests that run against the live API to tests/functional
Added type: ignores to some functional tests that are cumbersome to type

@leewang0 leewang0 requested review from ankitd33 and rmkonnur May 18, 2023 17:47
Copy link

@ankitd33 ankitd33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this pr is stainless!

Copy link
Collaborator

@rmkonnur rmkonnur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anothe day another sdk review

@leewang0 leewang0 merged commit e024d93 into main May 18, 2023
@leewang0 leewang0 deleted the lee/v0.0.1-patch branch May 18, 2023 20:38
@rmkonnur rmkonnur added the latest-stainless-poc The final commit before we overrode the Stainless SDK with the Fern SDK. label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
latest-stainless-poc The final commit before we overrode the Stainless SDK with the Fern SDK.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants