fix: apply updated schema on refresh #81
Conversation
test/schemaRefresh.js
Outdated
| for (let i = 0; i < 10; i++) { | ||
| await t.context.clock.tickAsync(200) | ||
| } |
There was a problem hiding this comment.
why are you ticking the clock in a loop?
There was a problem hiding this comment.
As mentioned this was from following the polling tests. I've now removed these.
There was a problem hiding this comment.
LGTM but I'd like to wait for another review from @codeflyer
|
@luke88jones I'm seeing a consistent failure on Node 18 due to a timeout. Because this hasn't happened in the past and because the new behavior you introduced may have interactions with the event loop, I'm tempted to think that this is a legitimate failure, although I'm not sure why it would happen just on Node 18 |
|
@simoneb Sorry for the silence on this I've been on paternity leave. It looks like one of the polling interval tests is timing out. I'll see what I can find. |
|
Thanks @luke88jones and no worries! If you could take a quick look since you were the author of this change, I would appreciate it. Shout if you find out something or if you think this requires too much work, in which case we can consider proceeding in a different way |
|
@simoneb I've just checked out the main branch locally I have the same failure. I'm trying to track down the issue but it looks to be something to do with closing the |
|
Good catch, thanks. Interesting that it only happens (seemingly) in Node 18. If that's the case it would be interesting to figure out why. |
fixes #80
replaceSchemaon the GQL instance